[EUWE] Don't lookup category names if tag tree view all #13308
Conversation
|
ugh, rails 5 and |
| @@ -44,17 +44,26 @@ def root_options | |||
| end | |||
|
|
|||
| def x_get_tree_roots(count_only, _options) | |||
| return @categories.size if count_only | |||
There was a problem hiding this comment.
There a reason the return was removed from the "master" version of this PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/57/files
There was a problem hiding this comment.
That was probably an oversight. May have to put in a PR to get this line into master
| else | ||
| kid_id = "#{parent.name}-#{kid.name}" | ||
| (@edit && @edit.fetch_path(:new, :filters, kid_id)) || (@filters && @filters.key?(kid_id)) | ||
| end |
There was a problem hiding this comment.
So this is the main savings here, correct? We are just avoiding building kid_id for each node since it is not used when @edit and @filters are blank, correct?
There was a problem hiding this comment.
Also, just noticed that contain_selected_kid is basically this exact same logic. Is it possible to refactor this so we don't have so much code duplication?
This is minor, don't bother if it isn't worth it. Also, we have already merged this in master, so we would probably want to go back and do this there as well, which might be a pain.
kbrock
force-pushed
the
config_groups_euwe
branch
2 times, most recently
from
1afeb3d to
5904f18
Compare
|
Checked commit kbrock@5904f18 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
| kids = parent.entries.map do |kid| | ||
| kid_id = "#{parent.name}-#{kid.name}" | ||
| select = (@edit && @edit.fetch_path(:new, :filters, kid_id)) || (@filters && @filters.key?(kid_id)) | ||
| select = selected_entry_value(parent, kid) |
There was a problem hiding this comment.
I should have asked this before... was this supposed to be a boolean or the value for that key? Seems like it should have been the value, but not sure.
kbrock
force-pushed
the
config_groups_euwe
branch
from
5904f18 to
24ab41c
Compare
|
@NickLaMuro is this better? |
This was executing a few hundred extra queries category.name is the culprit https://bugzilla.redhat.com/show_bug.cgi?id=1399345
kbrock
force-pushed
the
config_groups_euwe
branch
from
24ab41c to
c6fb39b
Compare
|
@NickLaMuro cool. I changed Will put in a master PR to get these changes into there. |
When building the tag tree in access control groups, the tag tree is not expandable. But building the node name (using
category.name) executes a few hundred extra queries (20%).This skips those queries.
Numbers are for small 5_7 db. numbers in larger DBS will increase for each tag and node in the db. But they don't complete for me within a few minutes, so it was too hard to get numbers.
/ops/explorerbefore/ops/explorerafterhttps://bugzilla.redhat.com/show_bug.cgi?id=1399345
This is the E version of #13301